Open
Conversation
Replace misspelled parameter `verifiedd_flags_list` with the correct `verified_flags_list` in QcFlagRepository.
Remove incorrect/duplicated identifier `verifiedd_flags_list` from the destructuring and mapping in QcFlagRepository.
Add optional runNumber filtering for GAQ summaries. Controller validation and handler accept runNumber query param and pass it to GaqService; GaqService forwards runNumber to QcFlagRepository and unwraps a single-run summary when requested. RunsPerDataPassOverviewModel tracks per-run RemoteData in _gaqSummary$, fetches GAQ summaries for visible runs, and RunsPerDataPassOverviewPage renders loading/success/failure states. These changes enable fetching and displaying GAQ data scoped to individual runs to reduce load and improve UX.
Make GAQ summary fetches run sequentially so to ease reduce load on the database.
…se load Make runNumber a required Joi parameter to prevent user stressing the database fetching data for all runs of a dataPass. Intended to be reverted once database query has been optimised.
Tighten Joi validation for GAQ summary by requiring dataPassId and runNumber to be positive numbers.
Adjust the runsPerDataPass overview test to match updated row and expected GAQ values.
Update qcFlags GAQ summary tests to include runNumber and strengthen request validation coverage.
isaachilly
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2071 +/- ##
==========================================
+ Coverage 45.55% 45.62% +0.06%
==========================================
Files 1031 1031
Lines 17196 17249 +53
Branches 3129 3136 +7
==========================================
+ Hits 7834 7870 +36
- Misses 9362 9379 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use RemoteDataSource and AbortController to make per-run GAQ summary fetches cancelable. Can be easily adapted to use an array of remotedatasources if in the future we decide to request them in parallel.
When updating the GAQ summary for a run, store the actual success payload instead of the raw remoteData object.
Add a test that captures outgoing GAQ summary requests and asserts each run triggers exactly one GAQ request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: